fix(concerto): fix bugs when id field has regex #630

DianaLease · 2023-03-24T00:24:07Z

Closes #629

Throws an error if an id is provided to factory. newResource() that does not match the regex of the identifying field
Fixes cli generate to generate an id that matches the regex if there is regex on the identifying field

Had to update the tests using "CAR_123" since that id did not match the regex for VIN and now caused an error to throw.

Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
Vital features and changes captured in unit and/or integration tests
Commits messages follow AP format
Extend the documentation, if necessary
Merging to main from fork:branchname

Signed-off-by: Diana Lease <[email protected]>

DianaLease requested review from dselman, mttrbrts and a team March 24, 2023 00:24

DianaLease changed the title ~~fix(concerto): fix bugs then id field has regex~~ fix(concerto): fix bugs when id field has regex Mar 24, 2023

DianaLease force-pushed the dlease/fix-id-with-regex-bug branch from 5b60a62 to e1506b8 Compare March 24, 2023 00:25

fix(concerto): fix bugs when id field has regex

7c6f05d

Signed-off-by: Diana Lease <[email protected]>

DianaLease force-pushed the dlease/fix-id-with-regex-bug branch from e1506b8 to 7c6f05d Compare March 24, 2023 00:25

mttrbrts approved these changes Mar 24, 2023

View reviewed changes

mttrbrts merged commit 77d216f into main Mar 24, 2023

mttrbrts deleted the dlease/fix-id-with-regex-bug branch March 24, 2023 09:26